Merge pull request #61 from pboyd04/EnttecUSBDMXPROBufferNoPoly

EnttecUSBDMXPRO Driver Buffer API Fix (No Polyfill)
This commit is contained in:
Frédéric Bolvin 2018-11-14 20:45:42 +00:00 committed by GitHub
commit 8499aa5829
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 8 deletions

View file

@ -12,8 +12,7 @@ var ENTTEC_PRO_DMX_STARTCODE = 0x00
function EnttecUSBDMXPRO(device_id, options) { function EnttecUSBDMXPRO(device_id, options) {
var self = this var self = this
options = options || {} options = options || {}
this.universe = new Buffer(513) this.universe = Buffer.alloc(513, 0);
this.universe.fill(0)
this.dev = new SerialPort(device_id, { this.dev = new SerialPort(device_id, {
'baudRate': 250000, 'baudRate': 250000,
@ -31,7 +30,7 @@ EnttecUSBDMXPRO.prototype.send_universe = function() {
if(!this.dev.writable) { if(!this.dev.writable) {
return return
} }
var hdr = Buffer([ var hdr = Buffer.from([
ENTTEC_PRO_START_OF_MSG, ENTTEC_PRO_START_OF_MSG,
ENTTEC_PRO_SEND_DMX_RQ, ENTTEC_PRO_SEND_DMX_RQ,
(this.universe.length) & 0xff, (this.universe.length) & 0xff,
@ -42,7 +41,7 @@ EnttecUSBDMXPRO.prototype.send_universe = function() {
var msg = Buffer.concat([ var msg = Buffer.concat([
hdr, hdr,
this.universe.slice(1), this.universe.slice(1),
Buffer([ENTTEC_PRO_END_OF_MSG]) Buffer.from([ENTTEC_PRO_END_OF_MSG])
]) ])
this.dev.write(msg) this.dev.write(msg)
} }

View file

@ -3,8 +3,7 @@
function Null(device_id, options) { function Null(device_id, options) {
var self = this var self = this
options = options || {} options = options || {}
this.universe = new Buffer(513) this.universe = Buffer.alloc(513, 0);
this.universe.fill(0)
self.start() self.start()
} }

View file

@ -28,5 +28,8 @@
"name": "MIT", "name": "MIT",
"url": "http://www.opensource.org/licenses/mit-license.php" "url": "http://www.opensource.org/licenses/mit-license.php"
} }
] ],
"engines": {
"node": ">=5.1.0"
}
} }